Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

frappe.github.io

Post reply on HN
Print view View original

51–60 of 92 posts

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#51

Post by thrownaway954 »

harunurhan wrote: post #25

Looks nice, 0 dependency, simple design but there is one issue... I see that you don't have a single unit test or integration or functional etc. Even if your in house developers know what they are doing (which is a myth, stuff will break) it's going to be difficult accept contributions from community without any tests that make (almost) sure existing features are working with the changes.

maybe you could start contributing to the project by helping writing some tests? i see that this is a library for a product that develop, so this might be a project they just extracted from that. as such it most likely was already has the "works on my box" seal of approval :)

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#52

Post by [deleted] »

methodin wrote: post #46
handbanana wrote: post #41

Earlier quoted context omitted.

I see where your coming from, but I disagree. This isn't a new OS, its a tiny charts library/utility. I'm more inclined to contribute because there are no tests. Either way, someone could PR tests if they wished. Perhaps your comment should have been such a PR? ;)

Why would lack of tests be a measure for your desire to contribute?

[deleted]

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#54

Post by bonyboy »

codazoda wrote: post #28
harunurhan wrote: post #25

Looks nice, 0 dependency, simple design but there is one issue... I see that you don't have a single unit test or integration or functional etc. Even if your in house developers know what they are doing (which is a myth, stuff will break) it's going to be difficult accept contributions from community without any tests that make (almost) sure existing features are working with the changes.

Some of us believe that tests increase work by 25% while only reducing defects by 60%. https://www.microsoft.com/en-us/research/wp-content/uploads/...

Microsoft uses WordPress?

TIL

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#55

Post by anon335dtzbvc »

foodstances wrote: post #45
harunurhan wrote: post #38

Earlier quoted context omitted.

I am glad that this approach works for you but I am not brave enough to use a new library without a single test.

I guess this project isn't for you then.

Well I would use it, but I wouldn't contribute, because I write all my code in a test driven programming way. AFAIK Chuck Norris writes the code first, never the test.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#56

Post by Fifer82 »

simplify wrote: post #36
sillysaurus3 wrote: post #30

Earlier quoted context omitted.

Judge work by what it does, not by what it doesn't have. Like users, programmers don't care whether programs have tests as long as it does what it needs to do.

Tests are a way to judge what it does. It does the judging for you, ensuring features work as advertised, and provide usage examples that are guaranteed to work.

They are also boring as fuck and assume no talent for a project of this scope.

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#57

Post by anon335dtzbvc »

XR0CSWV3h3kZWg wrote: post #33
harunurhan wrote: post #32

Earlier quoted context omitted.

So I should wait until stuff starts breaking, then start complaining.

If nothing breaks why would you complain?

It's not a question of wether something might break, it's a question of when will it break and how long a new introduced bug might be undetcted, that could have easily detected by some tests? Bugs always happen in projects, if someone says otherwise, he either proved his program to be correct (e.g. in COQ) or is wrong (and sometimes both :).

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#58

Post by dflock »

methodin wrote: post #46
handbanana wrote: post #41

Earlier quoted context omitted.

I see where your coming from, but I disagree. This isn't a new OS, its a tiny charts library/utility. I'm more inclined to contribute because there are no tests. Either way, someone could PR tests if they wished. Perhaps your comment should have been such a PR? ;)

Why would lack of tests be a measure for your desire to contribute?

Possibly because it doubles the amount of work to make small changes, because you also have to learn the testing setup and write tests for your change?

Re: Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

#60

Post by TheAceOfHearts »

boffinism wrote: post #16

Question: For codebases that are all about package managers Yarn, what's best practice for integrating something like this? Just push it into a 'vendor' folder?

It depends on how the library is implemented, so you're expected to look at the source.

If you're using something like Webpack and the library just places everything on the global scope, you can configure exports-loader [0]. That way you can reference the module as if it were written with CJS or ESM, without having to change the source.

If it's not published on npm, you can reference the git repo along with the specific release tag you want to use. My suggestion would be to fork the repo and point to your fork in package.json, so things continue to work if the original repo ever gets taken down.

[0] https://webpack.js.org/loaders/exports-loader/

Post reply on HN