Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: GitPlex – A new Git repo management server with code review

pmease.com

Post reply on HN
Print view View original

51–60 of 98 posts

Re: Show HN: GitPlex – A new Git repo management server with code review

#51

Post by robinshen »

miguelrochefort wrote: post #48
TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

I recommend you watch this: https://youtu.be/dSqLt8BgbRQ

Thanks for the link, bookmarked it for studying, :)

Re: Show HN: GitPlex – A new Git repo management server with code review

#52

Post by robinshen »

wyclif wrote: post #42

We created GitPlex to manage our own code as result of not satisfying with existing tools on the market "...not satisfying"? I think what you want to write here is something like this: "We created GitPlex to manage our own code as a result of dissatisfaction with existing tools on the market" or even better, a sentence shorter than that.

Thanks for pointing this out. Will get that fixed. Not a human language expert, but hope I can do better in computer languages, :)

Re: Show HN: GitPlex – A new Git repo management server with code review

#53

Post by skrebbel »

Folks, this is why you want to do code reviews inside your editors / IDEs. I like this project, but really what they did is build a read-only version of an IDE from the ground up. You already have one and you know it inside out.

I've found, as the OP did, that the GitHub/Lab/Bucket code review UIs strongly encourage nitpicking over code style and strongly discourage true insightful reviews on a design and architecture level. This happens simply because of the amount of effort your have to do to see and feel the wider impact of a pull request on your codebase. It's like looking at code with blinders on.

So what you want to do is checkout the pull request and use your editor. We made this a habit here at TalkJS and the quality, speed and usefulness of our code reviews skyrocketed.

Actually we take it one step further: we dropped the commenting interface altogether. Our code reviews are commits, with code comments by a particular format:

    // REVIEW(marcin
My colleague Marcin can find all reviews intended for him by grepping for `REVIEW(marcin`. Git ensures that even across merges and code changes, comments stay put, and once Marcin applies the review comment he removes the comment. He can reply by adding a comment in the same format.

The fact that review comments are right there in the git history also really helps track down complicated problems. Finally, we get the freedom of merging a PR anyway even though some things ought to be better, without losing track of the review comment. Obviously that's a code smell, but sometimes it's better to release first and refactor next day.

But even if you think this is insane and reviews don't belong in the code, I'd like to warmly encourage you to use your editor for reviews.

Re: Show HN: GitPlex – A new Git repo management server with code review

#54

Post by sdesol »

oneeyedpigeon wrote: post #33
TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

Right now, I would take a button to go to the previous revision of a file, showing the full file with the diff underneath. That way I could very easily 'browse' through the history of a file to find out things like when a particular change got introduced or just get a feel for its history. Why on earth don't github/bitbucket provide this? Surely it's a reasonable and common requirement? Or is there something inherent…

My product for GitLab and GitHub does this. This is an example of browsing diffs one by one:

https://gitsense.com/rapid-browsing-1.mp4

And this is an example of bulk diffs browsing:

https://gitsense.com/rapid-browsing-2.mp4

You can find the source for the chrome extension at

http://github.com/gitsense/insight

And the Git indexing engine at

http://gitsense.com/download

Edit:

It may not be obvious, but for the second example, I'm clicking the right arrow to quickly iterate through the diffs.

Re: Show HN: GitPlex – A new Git repo management server with code review

#55

Post by oneeyedpigeon »

sdesol wrote: post #54
oneeyedpigeon wrote: post #33

Earlier quoted context omitted.

Right now, I would take a button to go to the previous revision of a file, showing the full file with the diff underneath. That way I could very easily 'browse' through the history of a file to find out things like when a particular change got introduced or just get a feel for its history. Why on earth don't github/bitbucket provide this? Surely it's a reasonable and common requirement? Or is there something inherent…

My product for GitLab and GitHub does this. This is an example of browsing diffs one by one: https://gitsense.com/rapid-browsing-1.mp4 And this is an example of bulk diffs browsing: https://gitsense.com/rapid-browsing-2.mp4 You can find the source for the chrome extension at http://github.com/gitsense/insight And the Git indexing engine at http://gitsense.com/download Edit: It may not be obvious, but for the second e…

Yes, that second video is pretty much exactly what I'm looking for. I've been considering implementing it myself as a general-purpose git tool (i.e. not github etc. dependant) - were there any major gotchas? Do you need to pre-cache commit or diff info. or is it efficient enough to do everything in real-time?

Re: Show HN: GitPlex – A new Git repo management server with code review

#56

Post by robinshen »

sashaafm wrote: post #50

Could you please show us an example of "Preview pull request integration result and build status"? Thanks

Missed description of the integration preview part, now get it added: https://www.pmease.com/gitplex#preview-integration

Re: Show HN: GitPlex – A new Git repo management server with code review

#57

Post by leonya2 »

TeMPOraL wrote: post #38
oneeyedpigeon wrote: post #32

Earlier quoted context omitted.

The trouble with that is, how on earth do you get the annotations to apply across revisions? Or would you be OK with them only applying to a given revision and then ... what, disappearing? Or going into a 'floating bucket' of annotations for the entire file?

I'd be fine with them sticking to particular lines of code[0] and disappearing if those lines were changed. This is not something I'd like to commit into codebase, it's for exploration / preparing work. -- [0] - "smart stick" can be implemented by remembering not just the line in file, but also the contents of that line and a (fuzzy) context.

Upsource has sticky comments that survive code changes well.

Re: Show HN: GitPlex – A new Git repo management server with code review

#58

Post by sdesol »

oneeyedpigeon wrote: post #55
sdesol wrote: post #54

Earlier quoted context omitted.

My product for GitLab and GitHub does this. This is an example of browsing diffs one by one: https://gitsense.com/rapid-browsing-1.mp4 And this is an example of bulk diffs browsing: https://gitsense.com/rapid-browsing-2.mp4 You can find the source for the chrome extension at http://github.com/gitsense/insight And the Git indexing engine at http://gitsense.com/download Edit: It may not be obvious, but for the second e…

Yes, that second video is pretty much exactly what I'm looking for. I've been considering implementing it myself as a general-purpose git tool (i.e. not github etc. dependant) - were there any major gotchas? Do you need to pre-cache commit or diff info. or is it efficient enough to do everything in real-time?

The major gotchas is building the indexing engine. Once you have that in place, getting the commit information takes milliseconds. The only time consuming thing is extracting the from and to blobs from the repo. However, that is a one time hit, since you can cache the blobs.

For the diff, this is done in realtime with https://github.com/Microsoft/monaco-editor

Also my product isn't really dependent on GitLab or GitHub. It works in standalone mode as well.

Re: Show HN: GitPlex – A new Git repo management server with code review

#59

Post by Livven »

oneeyedpigeon wrote: post #33
TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

Right now, I would take a button to go to the previous revision of a file, showing the full file with the diff underneath. That way I could very easily 'browse' through the history of a file to find out things like when a particular change got introduced or just get a feel for its history. Why on earth don't github/bitbucket provide this? Surely it's a reasonable and common requirement? Or is there something inherent…

Some (if not most) GUI Git tools should do this, e.g. I personally use Git Extensions[1] which shows history and diff side-by-side.

For what it's worth, features like that (along with, say, line-by-line staging) are the reason why I usually use a GUI client and only drop down to the command line when necessary.

[1] https://github.com/gitextensions/gitextensions

Re: Show HN: GitPlex – A new Git repo management server with code review

#60

Post by robinshen »

TeMPOraL wrote: post #38
oneeyedpigeon wrote: post #32

Earlier quoted context omitted.

The trouble with that is, how on earth do you get the annotations to apply across revisions? Or would you be OK with them only applying to a given revision and then ... what, disappearing? Or going into a 'floating bucket' of annotations for the entire file?

I'd be fine with them sticking to particular lines of code[0] and disappearing if those lines were changed. This is not something I'd like to commit into codebase, it's for exploration / preparing work. -- [0] - "smart stick" can be implemented by remembering not just the line in file, but also the contents of that line and a (fuzzy) context.

Sticky comment is actually another form of git blame, and will be available in future versions of GitPlex.
Post reply on HN