Show HN: Frappe Charts – GitHub inspired JavaScript charting with zero dependencies

Post by revmoo » Tue, Oct 31, 2017, 8:51 PM UTC

simplify wrote: post #36

sillysaurus3 wrote: post #30

Earlier quoted context omitted.

Judge work by what it does, not by what it doesn't have. Like users, programmers don't care whether programs have tests as long as it does what it needs to do.

Tests are a way to judge what it does. It does the judging for you, ensuring features work as advertised, and provide usage examples that are guaranteed to work.

Post by dabernathy89 » Tue, Oct 31, 2017, 8:52 PM UTC

Post by methodin » Tue, Oct 31, 2017, 8:59 PM UTC

handbanana wrote: post #41

harunurhan wrote: post #25

Looks nice, 0 dependency, simple design but there is one issue... I see that you don't have a single unit test or integration or functional etc. Even if your in house developers know what they are doing (which is a myth, stuff will break) it's going to be difficult accept contributions from community without any tests that make (almost) sure existing features are working with the changes.

I see where your coming from, but I disagree. This isn't a new OS, its a tiny charts library/utility. I'm more inclined to contribute because there are no tests. Either way, someone could PR tests if they wished. Perhaps your comment should have been such a PR? ;)

Post by [deleted] » Tue, Oct 31, 2017, 9:06 PM UTC

harunurhan wrote: post #32

sillysaurus3 wrote: post #30

Earlier quoted context omitted.

Judge work by what it does, not by what it doesn't have. Like users, programmers don't care whether programs have tests as long as it does what it needs to do.

So I should wait until stuff starts breaking, then start complaining.

Post by pratu16x7 » Tue, Oct 31, 2017, 9:09 PM UTC

boffinism wrote: post #16

Question: For codebases that are all about package managers Yarn, what's best practice for integrating something like this? Just push it into a 'vendor' folder?