Live data from Hacker News

Show HN: GitMagic – Enforce your GitHub contribution guidelines

41–42 of 42 posts

Re: Show HN: GitMagic – Enforce your GitHub contribution guidelines

#41

Post by gitmagic » Fri, Feb 12, 2016, 9:36 PM UTC

kannonboy wrote: post #39

gitmagic wrote: post #26

Earlier quoted context omitted.

Our plans is to begin with GitHub support only, since it is (at the moment at least...) the most popular service. But later we plan to support both GitLab and Bitbucket too.

Sweet action! Depending on how far you want to go with the Bitbucket integration, you could potentially inject warnings on the commit, branch, and pull request pages using the Bitbucket Connect framework. One of our engineers wrote an add-on recently for enforcing some less automated aspects of CONTRIBUTING.md that you might be interested in too: https://blog.bitbucket.org/2016/01/26/pull-request-guideline...

Thanks, that sounds really cool and would definitely be something we will look into pretty soon :)

Re: Show HN: GitMagic – Enforce your GitHub contribution guidelines

#42

Post by fiatjaf » Sat, Feb 13, 2016, 5:16 PM UTC

tyre wrote: post #8

The API of your configuration could use some work. Have you looked at the validations present in JSON Schema[1]? Instead of { "commit": { "message_must_be_imperative_tense": true, "message_must_include_prefix": { "prefixes": ["feat", "fix", "docs", "refactor"], "require_after_prefix": " " } } } Something like: { "commit": { "message": { "imperative": true, "prefixes": ["feat ", "fix ", "docs ", "refactor "] } } } [1]…

I like "message_must_be_imperative_tense" much more. It is much clearer. it doesn't hurt to be so big since you're going to set it up just once.

Post reply on HN