It needs to be improved to be secure - salt. To avoid rainbow table attacks. One could use the login/email as salt - key strengthening function. Instead of repeating naively SHA-256 a few times, use PBDKF2 or even better, something which is also memory hard like scrypt. Finally. What happens when the password requires to have upper case, symbols, x number of digits, min or max number of characters... If you think abo…
It would be great if there was a site ran by a widely-trusted body (EFF for example) that tracks the various password requirements and limitations of websites. That way password managers, such as this one, can query that authoritative database for the idiosyncratic password rules for each domain and generate a password of the maximum allowable length and with the largest possible alphabet.