Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: Stage – Putting humans back in control of code review

stagereview.app

Post reply on HN
Print view View original

21–30 of 119 posts

Re: Show HN: Stage – Putting humans back in control of code review

#21

Post by embedding-shape »

It's an interesting idea, but I feel like it's missing almost the most important thing; the context of the change itself. When I review a change, it's almost never just about the actual code changes, but reviewing it in the context of what was initially asked, and how it relates to that.

Your solution here seems to exclusively surface "what" changes, but it's impossible for me to know if it's right or not, unless I also see the "how" first and/or together with the change itself. So the same problem remains, except instead of reviewing in git/GitHub/gerrit + figure out the documents/resources that lays out the task itself, I still have to switch and confirm things between the two.

Re: Show HN: Stage – Putting humans back in control of code review

#23

Post by dean_stratakos »

kylestlb wrote: post #22

I assume Gitlab/Github will add these sort of features to their products within the next few months

It's possible, but at the same time it's been years and they haven't copied things like Graphite's dashboard or stacked PR interface yet. We have the advantage of speed :)

Re: Show HN: Stage – Putting humans back in control of code review

#24

Post by cpan22 »

sebakubisz wrote: post #11

Can reviewers adjust the chapter splits manually if they disagree with how it grouped the PR, or are the chapters fixed once generated?

We're also planning on adding functionality to support some sort of CHAPTERS.md file that lets you specify how you want things broken down!

Re: Show HN: Stage – Putting humans back in control of code review

#25

Post by ryanjso »

tasuki wrote: post #17
ryanjso wrote: post #3

I like the chapters thing, a lot of PRs I review should really be like 5 prs so its nice to have it auto split like that. Do you see a world where it splits them up on the git level?

> a lot of PRs I review should really be like 5 prs Can't you push back on that? I feel like this tool is trying to fix misbehaved colleagues...

Yeah, but we're a small company and sometimes cut corners to move faster, so if a tool can solve this instead of potentially adding more friction to other engineers I'm all for it.

Re: Show HN: Stage – Putting humans back in control of code review

#26

Post by nathannaveen »

embedding-shape wrote: post #21

It's an interesting idea, but I feel like it's missing almost the most important thing; the context of the change itself. When I review a change, it's almost never just about the actual code changes, but reviewing it in the context of what was initially asked, and how it relates to that. Your solution here seems to exclusively surface "what" changes, but it's impossible for me to know if it's right or not, unless I a…

I assume this problem could be solved if we write up what we actually want (like a GH issue) and maybe in the future the guys at Stage could use github issues as part of their PR review?

Re: Show HN: Stage – Putting humans back in control of code review

#28

Post by cpan22 »

embedding-shape wrote: post #21

It's an interesting idea, but I feel like it's missing almost the most important thing; the context of the change itself. When I review a change, it's almost never just about the actual code changes, but reviewing it in the context of what was initially asked, and how it relates to that. Your solution here seems to exclusively surface "what" changes, but it's impossible for me to know if it's right or not, unless I a…

I agree, that's also really important and something we're brainstorming

Currently on Stage we also generate a PR summary next to the chapters and that's where we want to do more "why" that pulls in context from Linear, etc.

And I know there's a lot of cool teams like Mesa and Entire working on embedding agent context into git history itself so that could an interesting area to explore as well

Re: Show HN: Stage – Putting humans back in control of code review

#29

Post by cpan22 »

phyzix5761 wrote: post #20

This is a really cool idea but where's the moat? What's stopping someone from replicating the functionality?

Thanks! I think we're really focused on making the overall review experience as guided and obvious as possible for the human. Chapters is a great start but we're coming up with more ideas on how we can make the process even easier

Re: Show HN: Stage – Putting humans back in control of code review

#30

Post by tfrancisl »

Why is this a service and not an open source project? It doesn't seem to do much other than organize your commits within a PR (could be run once on a dev machine and shipped in the code, then displayed separately) and builds a dashboard for PRs that's not too far off from what github already offers, but could also be represented with fairly small structured data and displayed separately.
Post reply on HN