Live data from Hacker News

Show HN: A GitHub Action that quizzes you on a pull request

github.com

11–20 of 35 posts

Re: Show HN: A GitHub Action that quizzes you on a pull request

#11

That’s a fun take on a real issue, but… > Your code is only sent to the model provider (OpenAI) When has this become an acceptable « privacy » statement? I feel we are reliving the era of free mobile apps at the expense of harvesting any user data for ads profiling before GDPR kicked in…

That's not the privacy statement though. I feel like we're reliving the era of RTF... oh wait, we never left.

Re: Show HN: A GitHub Action that quizzes you on a pull request

#12

That’s a fun take on a real issue, but… > Your code is only sent to the model provider (OpenAI) When has this become an acceptable « privacy » statement? I feel we are reliving the era of free mobile apps at the expense of harvesting any user data for ads profiling before GDPR kicked in…

That's not the privacy statement though. I feel like we're reliving the era of RTF... oh wait, we never left.

Ok I’ll bite: putting « only » implies this is not a big deal and a lesser of 2 evils, between an AI model provider harvesting prompts for retraining and a 3rd party hosting provider most probably only storing logs for security and accountability…

So yes this is the second part of the privacy statement

Re: Show HN: A GitHub Action that quizzes you on a pull request

#15
post #14

I would probably be putting devs on a pip or firing them if they failed these quizzes often...understanding your own prs is the bare fucking minimum, even without AI help.

Won't be long before those people would just get AI to answer the quiz instead.

Re: Show HN: A GitHub Action that quizzes you on a pull request

#16

> AI Agents are starting to write more code. How do we make sure we understand what they're writing? This is a good question, but also how do we make sure that humans understand the code that _other humans_ have (supposedly) written? Effective code review is hard as it implies that the reviewer already has their own mental model about how a task could/would/should have been done, or is at the very least building thei…

Code review, to me, is not about validating the output. It's about a 2nd set of eyes to check for foot guns, best practice, etc. Code review is one step above linting and one step below unit tests, for me.

If someone were to submit this code for review:

    getUser(id: number): UserDTO {
        return this.mapToDTO(this.userModel.getById(id));
    }
and I knew that `userModel` throws an exception when it doesn't find a user (and this is typescript, not java, where exceptions are not declared in the method prototype) then I would tell them to wrap it in a try-catch. I would also probably tell them to change the return type to `UserDTO | null` or `Result` depending on the pattern that we chose for the API. I don't need to know anything about the original ticket in order to point these things out, and linters most likely won't catch them. Another use for code review is catching potential security issues like SQL injection that the linter or framework can't figure out (i.e, using raw SQL queries in your ORM without prepared statements)

Re: Show HN: A GitHub Action that quizzes you on a pull request

#17

Just submit a PR that removes the action so it doesn't run on the branch before the merge! If devs aren't reviewing the code anyways, will they even catch that kind of change?

You could set up some hardcoded rules so that the PR is never merged without human review if it touches the github actions.

Re: Show HN: A GitHub Action that quizzes you on a pull request

#18
post #17

Just submit a PR that removes the action so it doesn't run on the branch before the merge! If devs aren't reviewing the code anyways, will they even catch that kind of change?

You could set up some hardcoded rules so that the PR is never merged without human review if it touches the github actions.

You could, but it would be mad to skip the code review because it "only" touches customer-facing code rather than GHA.
Post reply on HN