What does it do apart from the call graph? If I had jump-to-definition and find-references in the line-by-line code review UI, what extra benefits would I have by using Haystack?
Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
11–20 of 23 posts
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#12This is promising.
Does it works on local without any login? I review github pull requests in vscode and this seems extention of that workflow where I can visualise the PR
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#13I think I understand what it does and it looks interesting and appealing. My team would need Ruby support. Not sure if you'll be able to connect the graph properly in Ruby, but it might still be useful.
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#14I think I understand what it does and it looks interesting and appealing. My team would need Ruby support. Not sure if you'll be able to connect the graph properly in Ruby, but it might still be useful.
We would need ruby support too.
Beyond that, if my MR/PR has two (or more) logical commits, will the tool support reviewing each in isolation? Often times, I will do a refactor in the first commit, and have a second commit with the new feature that makes use of the refactor. Reviewing it all together can result in muddying the water.
Another thought: if I edit a function to call a different function defined elsewhere in my codebase, is there a way to include that functions definition into the canvas (either by the author in preparation for a reviewer, or by the reviewer) to facilitate verifying the behavior across this new boundary?
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#15This is promising. Does it works on local without any login? I review github pull requests in vscode and this seems extention of that workflow where I can visualise the PR
As of now, you need to log in on desktop to review pull requests. Theoretically, we would not require login if your pull requests are in a public repo. If that's the case, I can get a change in for this ASAP!
EDIT: By log in, I mean you have to log in to GitHub. There's no separate Haystack log in.
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#16I think I understand what it does and it looks interesting and appealing. My team would need Ruby support. Not sure if you'll be able to connect the graph properly in Ruby, but it might still be useful.
We can get it working with Ruby ASAP!
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#17I think I understand what it does and it looks interesting and appealing. My team would need Ruby support. Not sure if you'll be able to connect the graph properly in Ruby, but it might still be useful.
We would need ruby support too. Beyond that, if my MR/PR has two (or more) logical commits, will the tool support reviewing each in isolation? Often times, I will do a refactor in the first commit, and have a second commit with the new feature that makes use of the refactor. Reviewing it all together can result in muddying the water. Another thought: if I edit a function to call a different function defined elsewhere…
You can review each commit in isolation! Also, you can CMD+Click on that new function and it should create a view of that function on the canvas, along with a connector.
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#18Looks great! I'll be looking out for gitlab integration
I'll let you know when we have this up!
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#19What does it do apart from the call graph? If I had jump-to-definition and find-references in the line-by-line code review UI, what extra benefits would I have by using Haystack?
> If I had jump-to-definition and find-references in the line-by-line code review UI
I think the main benefit of Haystack is that it allows you to keep a model of how the pull request works on the canvas, rather than manually needing to gain an understanding of it in your head.
Even with goto definition/references, I need to understand what parts of the pull request are net new and work together (e.g. I created a new function A that relies on a new class B and calls a new function C) and what parts are linked with existing parts of the codebase.
Normally, this would require me to do some digging around, but with Haystack a lot of this work is done for me in a visual way, allowing me to understand a pull request significantly faster.
Re: Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
#20Looks really great! I'm definitely interested in self hosting