Select options are white on white background in Firefox. And it would be nicer, if changing language and time wouldn't reload whole page.
Show HN: Trends – A GitHub trending PWA
11–20 of 34 posts
Re: Show HN: Trends – A GitHub trending PWA
#12Never used next, looks interesting. So with this setup, the browser doesn't do any work, all pages are loaded as if they were static, and rendered server side?
Correct! The way that is achieved is pretty neat, Next.js has a [1] component that you can extend. This Document is essentially your application shell that is used when server side rendering. Here is the trends Document component[2] where you can see I'm simply omitting `NextScripts` which ends up being the frontend bundle with react + application code [1] https://github.com/zeit/next.js#custom-document [2] https://g…
I'd seen references to next before this but never really dug in deep enough to get a sense of whether it was worthwhile. Thanks for giving it enough context to show how cool and accessible next is.
Re: Show HN: Trends – A GitHub trending PWA
#13Select options are white on white background in Firefox. And it would be nicer, if changing language and time wouldn't reload whole page.
hmm, thanks for mentioning the select options .. should be an easy fix.
As for the page reloading I agree, but this exercise was specifically to make an application with the absolute minimum amount of client side code.
HTMl5 Forms do the job pretty well! :)
Re: Show HN: Trends – A GitHub trending PWA
#14Cool. Just curious if this is supposed to be just an exercise or does it have information that's not on github's own trending page?
I'm using the search API, so unlikely anything different than Github's trending stuff that is already there.
The UI is a little better though ;)
Re: Show HN: Trends – A GitHub trending PWA
#15The page load speed is seriously impressive, congrats! There's something weird going on with the styling of the dropdowns, though: https://i.imgur.com/WQ3m52X.gif I'm on Windows 10 & Chrome
I'm having the same issue in OSX firefox.
Re: Show HN: Trends – A GitHub trending PWA
#16Changing the width or zooming in and out changes the number of columns (nice!), but the max seems to be 4. Is that a hard limit? Seems like a responsive UI should respect wider screens in landscape.
Nice work, btw.
Re: Show HN: Trends – A GitHub trending PWA
#17The page load speed is seriously impressive, congrats! There's something weird going on with the styling of the dropdowns, though: https://i.imgur.com/WQ3m52X.gif I'm on Windows 10 & Chrome
I'm having the same issue in OSX firefox.
May need to do a hard refresh because of the aggressive caching, but this should be fixed now!
Re: Show HN: Trends – A GitHub trending PWA
#18The page load speed is seriously impressive, congrats! There's something weird going on with the styling of the dropdowns, though: https://i.imgur.com/WQ3m52X.gif I'm on Windows 10 & Chrome
just rolled out a fix for this on firefox for mac, i don't have a windows computer to test the fix on...
if you do a hard refresh this issue may be resolved! ¯\_(ツ)_/¯
Re: Show HN: Trends – A GitHub trending PWA
#19The page load speed is seriously impressive, congrats! There's something weird going on with the styling of the dropdowns, though: https://i.imgur.com/WQ3m52X.gif I'm on Windows 10 & Chrome
On a similar note, it'd be nice if there were an arrow indicating it was a dropdown in the first place.
Re: Show HN: Trends – A GitHub trending PWA
#20Changing the width or zooming in and out changes the number of columns (nice!), but the max seems to be 4. Is that a hard limit? Seems like a responsive UI should respect wider screens in landscape. Nice work, btw.
yeah I added a hard limit based on a relatively arbitrary max-width of 1400px.
I got all of the responsiveness for free using CSS grid! Definitely recommend checking it out if you haven't yet
Figured something like this would be a little overwhelming https://imgur.com/nx3hISb