Live data from Hacker News

Show HN: Encrypted Communication via GitHub Using Node.js and SSH Keys

github.com

11–20 of 47 posts

Re: Show HN: Encrypted Communication via GitHub Using Node.js and SSH Keys

#11
post #9
post #7

Earlier quoted context omitted.

function encrypt(public_key, file) { var pem_pub_key = sshKeyToPEM(public_key); // convert rsa to pem var chunks = []; var buffer = new Buffer(fs.readFileSync(file, 'utf8')); // work around for 214 character limit for encrypting // text with small openssh rsa pub key for (var i = 0; i According to the docs, crypto.publicEncrypt uses OAEP by default, so the bulk of the terribleness should mainly be how horribly slow t…

OAEP doesn't allow you to encrypt variable-length data. They may very well be using OAEP, but that's not my point.

It's awful crypto and it made me throw up in my mouth a little bit. They should be using RSA to encrypt a random key then encrypting the rest of the message with some sort of authenticated encryption.

Re: Show HN: Encrypted Communication via GitHub Using Node.js and SSH Keys

#14
post #13
post #2

Is this what I think it is? An ECB-mode RSA implementation?

What is an ECB-mode RSA? Is it using RSA as a block cipher of blocksize order-1 ? And padding each block and concatenate them?

https://news.ycombinator.com/item?id=10186372

Re: Show HN: Encrypted Communication via GitHub Using Node.js and SSH Keys

#16
post #12

To function, both the reader and writer have to download special software. If you're going to do that, why not just have both sides download PGP?

Maybe GitHub is being treated as a trusted key exchange intermediary?

... but I guess if people want to do that, they can already accomplish it with Keybase. And PGP.

Re: Show HN: Encrypted Communication via GitHub Using Node.js and SSH Keys

#17
post #16
post #12

To function, both the reader and writer have to download special software. If you're going to do that, why not just have both sides download PGP?

Maybe GitHub is being treated as a trusted key exchange intermediary? ... but I guess if people want to do that, they can already accomplish it with Keybase. And PGP.

If you trust my Github account, why wouldn't you trust a Github repository with my PGP key in it?

Re: Show HN: Encrypted Communication via GitHub Using Node.js and SSH Keys

#18
post #17
post #16

Earlier quoted context omitted.

Maybe GitHub is being treated as a trusted key exchange intermediary? ... but I guess if people want to do that, they can already accomplish it with Keybase. And PGP.

If you trust my Github account, why wouldn't you trust a Github repository with my PGP key in it?

Indeed, or even a GitHub profile with your PGP key in it. I'm persuaded there's no benefit to this model.
Post reply on HN