Ask HN: How many code reviewers should you require?

#1

Post by dukerutledge » Thu, May 11, 2023, 1:28 AM UTC

No post body was provided.

Re: Ask HN: How many code reviewers should you require?

#2

Post by akerl_ » Thu, May 11, 2023, 1:30 AM UTC

It depends.

Re: Ask HN: How many code reviewers should you require?

#3

Post by crop_rotation » Thu, May 11, 2023, 1:36 AM UTC

Keep the entire team as optional but most reviews can be done by 1 or max 2 people.

Re: Ask HN: How many code reviewers should you require?

#4

Post by idlephysicist » Thu, May 11, 2023, 1:51 AM UTC

Two sets of eyes is ideal.

Making use of things like GitHub CODEOWNERS files can be very useful too, allowing for certain directories to require reviews from certain individuals or user groups. For example, a directory containing the Helm Chart for a service might require a review from someone in the infrastructure team.

Re: Ask HN: How many code reviewers should you require?

#5

Post by alex_lav » Thu, May 11, 2023, 2:21 AM UTC

0-2.

More than 2 is unnecessary.

Re: Ask HN: How many code reviewers should you require?

#6

Post by yobid20 » Thu, May 11, 2023, 2:57 AM UTC

0. I commit and push directly to master.