Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Ask HN: What are the best tools for code reviews?

news.ycombinator.com

Post reply on HN
Print view View original

51–55 of 55 posts

Re: Ask HN: What are the best tools for code reviews?

#51

Post by idel »

If you have the need to review VBA, but detest the VBE, then the open-source Rubberduck VBA add-in is essential for code parsing and review - and many more features beyond. Disclaimer - I'm a contributor.

Rubberduck VBA - http://rubberduckvba.com/ GitHub - https://github.com/rubberduck-vba/Rubberduck

The parser is one of the most robust parsers for VBA available, and the code fixes and refactoring tools allow you to quickly apply suggested improvements. The parser is COM aware, so it will even analyze the in-house/3rd-party add-ins and libraries/controls that you use within your projects.

There's full support across all VBA hosts (Eg. Excel, Word, Access, PowerPoint, AutoCAD, SolidWorks, CorelDRAW, Publisher, etc) and soon, there'll be support for VB6.

The integrated add-in is feature rich, but there's also an online review tool at http://rubberduckvba.com/Inspections/List

Re: Ask HN: What are the best tools for code reviews?

#53

Post by rtfpessoa »

mfontani wrote: post #22

My personal best tool for a Git branch's code review is `git lfo`, where the alias expands to: git log --pretty=full --reverse --show-notes=* -p --abbrev-commit origin/master.. Coupled with a "good diff highlighter", i.e. `diff-highlight | less --tabs=4 -RFX`… I'm set. I've yet to see a tool that allows me to review all commits as well as code, as easily. I don't only review a branch as a whole, i.e. `git diff master…

You should also take a look at https://diff2html.xyz/ and it's integration with https://diffy.org/ to share diffs with co-workers, also both Open Source. (Disclaimer: I created diff2html)

Re: Ask HN: What are the best tools for code reviews?

#54

Post by rbbitbucket »

usr1106 wrote: post #49

Suprised that nobody mentioned bitbucket. First a word of warning. There are 2 Bitbuckets: The online tools hosted by Atlassian and the traditional license where install on your own server. The functionality is similar but not identical, they are 2 different implementations. Using the same name is just a marketing thing. I have only used the installed version, not the hosted online version. The basic PR structure is…

Bitbucket Server PM here. I wanted to address some of these points as there's good news on many of them...

Regarding PR comments and line comments, file level comments have also been available from the beginning. There's a comment button above the diff view for this.

Regarding line comments being "lost", it's true that when they become outdated they can be harder to get to, but they're available. If you go to the activity tab all past comment threads are available to help make sure you've not missed anything. We're working on ways to show outdated comments in the diff view, and beyond that we're looking at adding more to our search capability for finding comments across pull requests.

For author and committer treatment, we do respect the two concepts in Git, but you're right that we don't display them clearly in the UI. We added coverage for returning both roles in the API back in 5.0, and at some point we'll probably update the UI to display it.

I'd love to hear more about what you feel is lacking in the diff view. We're doing some work there now so perhaps we can cover off your use case (or plan to already).

Re: Ask HN: What are the best tools for code reviews?

#55

Post by sytse »

togusa2017 wrote: post #47
arjun27 wrote: post #36

Earlier quoted context omitted.

Can you elaborate? Which functionality?

1. In Gitlab, after you get +2, you can still commit changes and merge. Gerrit will make sure that you seek +2 again on the new set of commits. 2. Gerrit allows you to create draft comments on review and submit all comments in one shot after u reveiew them. 3. Require +2 rather then two +1 is a very interesting idea in Gerrit

There is a setting in GitLab to have people approve again after you change the merge request.
Post reply on HN