41–50 of 54 posts
Non-stop complaining. Totally kills optimism and energy of an entire team. Complaining is contagious too, so it's not long before 1 chronic complainer infects the team. I don't mean focused retrospectives, which is time set aside to constructively address things worth complaining about.
Teams that don't take responsibility for their fuck ups. "Oh, that's your code." Yes, it's in our repo, but you wrote it in service of your needs. "We need you to help us get this out this week" well then you should have started sooner.
Hate it when director joins regular meeting and brings a lot of confusion with their little domain knowledge but speaking loudly thei ideas...
And also when people try to understand what business value brings shifting a button from right to left and talking about it for 40min.
When my job description gets expanded. I am a rails/elixir dev. I don't do ops, that is a hard and complex job that takes practice to be good at. I respect the ops team. I can't just dip in and do one of their tickets when things are slow. There is no such thing as full stack. Unless the stack is super small.
Non-stop complaining. Totally kills optimism and energy of an entire team. Complaining is contagious too, so it's not long before 1 chronic complainer infects the team. I don't mean focused retrospectives, which is time set aside to constructively address things worth complaining about.
Pull requests which have artificial requirements. Which, these days, may mean many things. It's illusion that PR can usually be compact in terms of lines and files. That not only requires a good quality of code, which isn't ubiquitous, but also good understanding of code, which changes all the time with different opinions resulting in that code being modified. So PRs become rather large - and sometimes surprisingly m…
"Reduce the scope of your PR" a reviewer comments on a PR for a project that hasnt meaningfully addressed its technical debt in years.
The frustrating part is ALWAYS needing to clean up before making any contribution.
So following the advice, you always need two PRs.
Earlier quoted context omitted.
> its just someone willing to gun for it/jump through hoops You mean motivated people with stronger work ethics? There’s a lot more to life than being smart.
I think the concern is that those hoops don’t represent or equal quality management.
1) He/she may not know how to actually manage people.
Earlier quoted context omitted.
"Reduce the scope of your PR" a reviewer comments on a PR for a project that hasnt meaningfully addressed its technical debt in years.
I think this may be a valid point, and cleaning up could be seen as a separate concern. The frustrating part is ALWAYS needing to clean up before making any contribution. So following the advice, you always need two PRs.
Earlier quoted context omitted.
I think this may be a valid point, and cleaning up could be seen as a separate concern. The frustrating part is ALWAYS needing to clean up before making any contribution. So following the advice, you always need two PRs.
Depends on the cleanup no? I mean, if it's just obselete version of one library, and the ensuing lockfile change, it doesn't really matter. If iys upgrading to a new language/framework however, yes, please do so.
But it isn't always legacy that needs cleaning up.
It can also be mess created very recently by active team members.
So on the one hand, a separate PR for the cleaning up is warranted, but since it isn't being matched with a separate PR for introducing the mess, the double standard is magnified by introducing more book-keeping for those who clean up after others.
For that reason, when working with messy people who are not held accountable, I usually clean up in separate commits in a PR. This way, when looking at the blame for the logical changes that I introduced, and when reviewing, this is separate from the cleanup.
Mine is when people start talking about XDR, SIEM or SOAR systems. There's so much bullshit going on in the cyber security scene, it's ridiculous. From supposed "AI driven network analysis" to "data enrichment pipelines"... everything is built as Enterprise as possible, and as useless as possible. An XDR system that costs more than 500k per month and cannot even show the geolocation of an IP it's supposed to be able…