Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Ask HN: What open source project, in your opinion, has the highest code quality?

news.ycombinator.com

Post reply on HN
Print view View original

281–290 of 294 posts

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#281

Post by Drdrdrq »

deanishe wrote: post #185
raverbashing wrote: post #63

Earlier quoted context omitted.

But to be honest, this is mostly fair criticism. Not sure why they need some of those things, but if they need it, then it's fine.

It's explained in more depth here: https://fossil-scm.org/fossil/doc/trunk/www/fossil-v-git.wik... Essentially, git is designed for the "bazaar" development model, while Fossil is designed for the "cathedral" one, which is what SQLite uses, being developed by just three guys working very closely together.

Thos is not the reason. The real reasons are explained quite nicely here [0] and I agree with all of them - though I still use Git because of network effects. My alternative of choice would be hg.

[0] https://sqlite.org/whynotgit.html

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#283

Post by ChrisRackauckas »

tlamponi wrote: post #261
ChrisRackauckas wrote: post #224

Julia. Julia / Julialang is so pedantically tested and the names are pretty meticulously chosen. The algorithms in Base are almost all generic and handle a very wide variety of inputs without catering to them. If you want to learn Julia, along with good software engineering, looking at the Base library is quite recommended.

Did not look to much into it but at least a packager from Alpine Linux does not think Julia's compiler ecosystem is clean/easy to work with: http://lists.alpinelinux.org/alpine-devel/6248.html But as said, I did not really checked this claim for validness myself...

Julia requires patched versions of things like LLVM in order for all tests to pass because upstreaming bugfixes take time. This has given some Linux package managers an issue since they try to build using system LLVM/OpenBLAS/etc. with the known bugs. I agree this does cause some distribution problems, but as a scientist and mathematician I do like that the standard distribution of Julia uses the most numerically correct versions (as of current knowledge) of the dependencies as it can, and has a test to identify known potential issues. To me this is good practice.

But anyways, I was talking about the Julia Base library and its numerical routines. I just look at the Julia code and don't touch the build systems.

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#284

Post by wrasee »

coldnose wrote: post #244

After spending about a month of concerted effort pouring through the zlib sources, looking for vulnerabilities, I can say that zlib is the most astonishingly bug-free code I've ever seen. But in the conventional understanding of "code quality", it's pretty bad.

Julian Storer (JUCE library) did a talk on code quality using zlib as an example. Might be interesting to you if you've not seen it already.

https://www.youtube.com/watch?v=SIAAvv1O7Gg

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#285

Post by rick22 »

rusk wrote: post #82
akavel wrote: post #38

I hold the source code of Go standard library & base distribution (i.e. compiler, etc.) in very high regard. Especially the standard library is, in my opinion, stunningly easy to read, explore and understand, while at the same time being well thought through, easy to use (great and astonishingly well documented APIs), of very good performance, and with huge amounts of (also well readable!) tests. The compiler (includ…

> standard library is, in my opinion, stunningly easy to read Reading this brought to mind the JDK. All well structured, neatly formatted and well documented. I’ll often just click thru to the source to get the nitty-gritty on a function, I rarely need to consult the actual docs!

not c++ stl. Very obscure.

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#286

Post by rurban »

codemusings wrote: post #104
rurban wrote: post #20

Earlier quoted context omitted.

for sure not. OpenBSD makes no attempt to use proper performance which is critical for a kernel. there are so many naive ad-hoc data structures and algos, it's a shame to walkthrough.

How is performance related to code quality. That makes no sense. If anything, if you had to inline ASM for example, the code would suffer from readability.

using comma seperated string splitting options over normal bits or'ed together in their public API looses all credibility in their engineering abilities. it would not survive any professional code review.

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#287

Post by rusk »

rick22 wrote: post #285
rusk wrote: post #82

Earlier quoted context omitted.

> standard library is, in my opinion, stunningly easy to read Reading this brought to mind the JDK. All well structured, neatly formatted and well documented. I’ll often just click thru to the source to get the nitty-gritty on a function, I rarely need to consult the actual docs!

not c++ stl. Very obscure.

Some would consider that a virtue

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#289

Post by travmatt »

andygrunwald wrote: post #18

When we take the language into consideration, unwound like to mention Redis. Often codebases written in C are a a mess to understand, a mess to read. The Redis Source Code is understandable even without deep knowledge of C

> Redis Source Code is understandable even without deep knowledge of C

Came here to say exactly this - Redis is very cleanly written.

Re: Ask HN: What open source project, in your opinion, has the highest code quality?

#290

Post by nojvek »

ioddly wrote: post #280
nojvek wrote: post #277

Typescript Even though it’s a fairly complex transpiler, the authors did a good job modularizing and leaving lots of contextual comments on what each part does. Also typescript baseline tests are a simple but very effective way to get lots of coverage on the compiler. I’ve read source code for Babel, typescript, coffeescript and flow. Typescript architecture stands out. Typescript not only does fascinating things lik…

I found the TypeScript type checker pretty hard to read through, though it may be my lack of, well, almost any knowledge about type theory. I didn't dig much into the other parts of the codebase however. What parts of it do you enjoy reading?

While submitting a PR, the parser, Lexor and emitter were fairly easy to understand.
Post reply on HN